Skip to content

Number unboxing #2069

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 3 commits into
base: master
Choose a base branch
from
Open

Number unboxing #2069

wants to merge 3 commits into from

Conversation

vouillon
Copy link
Member

@vouillon vouillon commented Jul 3, 2025 •
edited
Loading

We avoid boxing numbers (within a function) if the boxed value is never actually used.

This makes some microbenchmark like almabench and fft significantly faster. This also helps for lexifi-g2pp.

@vouillon vouillon force-pushed the number-unboxing branch 4 times, most recently from 2883aac to ca76fc0 Compare July 7, 2025 10:05
@hhugo hhugo added the wasm label Jul 7, 2025
@vouillon vouillon force-pushed the number-unboxing branch 3 times, most recently from 6e903a2 to 65e2b4f Compare July 9, 2025 16:21
@vouillon vouillon mentioned this pull request Jul 10, 2025
Draft
8 tasks
@vouillon vouillon force-pushed the number-unboxing branch 3 times, most recently from d9e6a36 to 238eb5e Compare August 19, 2025 16:55
@vouillon vouillon marked this pull request as ready for review August 20, 2025 09:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
1 more reviewer

@dadad9 dadad9 dadad9 approved these changes

Reviewers whose approvals may not affect merge requirements
Assignees
No one assigned
Labels
wasm
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@vouillon @dadad9 @hhugo